Gabor Kaszab has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page ......................................................................
Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/7363/11/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: PS11, Line 214: string GetProcessStartTime() { : if (CommonMetrics::PROCESS_START_TIME == nullptr) { : return "Error: Process start time can't be retrieved."; : } : return CommonMetrics::PROCESS_START_TIME->value(); : } > still would prefer you moved this into RootHandler - if CommonMetrics::PROC Done http://gerrit.cloudera.org:8080/#/c/7363/11/be/src/util/default-path-handlers.h File be/src/util/default-path-handlers.h: PS11, Line 40: /// Retrieves the process start time from CommonMetrics : string GetProcessStartTime(); > remove (callers should just check CommonMetrics::PROCESS_START_TIME). Done -- To view, visit http://gerrit.cloudera.org:8080/7363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05ae2f80835b1b0e4bc3b38731778ba0871338a4 Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
