Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler ......................................................................
Patch Set 7: (3 comments) PS6 rebases PS5. PS7 addresses Tim's comments. http://gerrit.cloudera.org:8080/#/c/4554/5/be/src/benchmarks/scheduler-benchmark.cc File be/src/benchmarks/scheduler-benchmark.cc: Line 18: #include <iostream> > Nit: I personally think we should treat gutil as being part of our source t Done PS5, Line 46: Blocks and files > This doesn't seem right. Done http://gerrit.cloudera.org:8080/#/c/4554/5/be/src/scheduling/scheduler.h File be/src/scheduling/scheduler.h: Line 346: /// first. If more than one of the replicas run an impala executor, then the 'memory > What do you think about adding a comment here, or maybe in the .cc pointing Good idea, done. -- To view, visit http://gerrit.cloudera.org:8080/4554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8df865c2e Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
