Tim Armstrong has posted comments on this change. Change subject: IMPALA-5636: changed the format metadata of repetition level from bit_packing to RLE ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7514/2//COMMIT_MSG Commit Message: Line 8: I'm ok with manually testing this change. We have testing that we can read back Parquet files (e.g. test_insert.py). Could you include a "Testing:" section in the commit message with the relevant lines of parquet-tools output, so reviewers can see the result. http://gerrit.cloudera.org:8080/#/c/7514/2/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: Line 172: column_encodings_.insert(Encoding::RLE); We can just delete this line - it's redundant with line 171. -- To view, visit http://gerrit.cloudera.org:8080/7514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4112ec88e8f4050d28661d27f9227450288a6756 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
