Tim Armstrong has posted comments on this change. Change subject: IMPALA-5739: Correctly handle sles12 SP2 ......................................................................
Patch Set 2: Verified+1 Thanks Hector! I don't think there's any point running our standard pre-commit tests since they don't exercise this. I manually verified that toolchain bootstrapping works on Ubuntu: tarmstrong@tarmstrong-box:~/Impala/incubator-impala$ rm -rf toolchain/cmake-3.2.3-p1/ tarmstrong@tarmstrong-box:~/Impala/incubator-impala$ ./bin/bootstrap_toolchain.py URL https://native-toolchain.s3.amazonaws.com/build/424- b9179e1169/cmake/3.2.3-p1-gcc-4.9.2/cmake-3.2.3-p1-gcc-4.9.2-ec2-package-ubuntu-16-04.tar.gz Downloading cmake-3.2.3-p1-gcc-4.9.2-ec2-package-ubuntu-16-04.tar.gz to /home/tarmstrong/Impala/incubator-impala/toolchain Extracting cmake-3.2.3-p1-gcc-4.9.2-ec2-package-ubuntu-16-04.tar.gz -- To view, visit http://gerrit.cloudera.org:8080/7535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I005e05b8b66de78e6d53a35a894eb34d89843a62 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: [email protected] <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
