Pooja Nilangekar has posted comments on this change. Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7513/1/be/src/exec/scanner-context.cc File be/src/exec/scanner-context.cc: PS1, Line 335: SkipStreamIfEosr(); > Just a passing comment - if this DCHECK fails, all it will tell us via the I uploaded another patch but didn't publish it. I've moved the checks to a single function and I am now checking both conditions. http://gerrit.cloudera.org:8080/#/c/7513/1/be/src/exec/scanner-context.h File be/src/exec/scanner-context.h: PS1, Line 332: > consider case where current_idx_ < 0 as well? Done -- To view, visit http://gerrit.cloudera.org:8080/7513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I026f7a005ba4d6fc412ca0884f4fa0459da9c885 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-HasComments: Yes
