Tim Armstrong has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down ......................................................................
Patch Set 2: (1 comment) Looks good to me, just one minor thing. http://gerrit.cloudera.org:8080/#/c/7539/3/be/src/service/fe-support.cc File be/src/service/fe-support.cc: Line 431: status.ToThrift(&result.status); I think we should pull this out of the if() to be more correct. As-is result.status is only "OK" by coincidence, since OK == 0 == the default uninitialized value. -- To view, visit http://gerrit.cloudera.org:8080/7539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic695faf89b146bdaa145aaca87f85579137b67c5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
