Lars Volker has posted comments on this change.

Change subject: IMPALA-5616: Add --enable_minidumps startup flag
......................................................................


Patch Set 2:

(2 comments)

Thanks for the reviews. I will rebase next.

http://gerrit.cloudera.org:8080/#/c/7541/2/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

PS2, Line 216:     """Check that setting the minidump_path to an empty value 
disables minidump creation.
             :     """
> update
Done


PS2, Line 219: 0
> nit: False
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2039b9140e1c281810b27b76140e2105198bc37
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to