Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() ......................................................................
Patch Set 1: I think the side-effects are more controlled now. Previously if the MemTracker was destroyed, we would have touched invalid memory. Now at least the memory is valid so the behaviour is defined. The new DCHECK in UnregisterFromParent() means the leak check is just as strong on the debug build. -- To view, visit http://gerrit.cloudera.org:8080/7492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
