John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS4, Line 1963: exec_env->metrics(), FLAGS_fe_service_threads, ThriftServer::ThreadPool); > Let's make this change for beeswax as well. Running this change through run-all-tests and changing the comment at 1954 to be: "ODBC and Hue drivers do not support non-blocking servers." similar to the comment at line 1976. I'm guessing at the intent of the old comment. After this change the only thing using ThreadPool server implementation is network-perf-benchmark.cc Not sure what the network-perf-benchmark.cc is used for, but if nothing else is using ThreadedPool implementation should I just remove support for it from ThriftServer() to prevent bit rot in the unused code paths? Or just leave it be for future use (or just for the network-perf-benchmark to use?) PS4, Line 1985: Threaded > Maybe we can just remove Threaded and ThreadPool and just pass in the numbe Does it matter that FLAG_enable_accept_queue_server can be turned to false and that these thread limits will not be enforced? Or at this point is there enough confidence that the accept_queue_server is good/stable enough and won't be disabled? If that is the case, should the flag be deprecated and the special case code be removed for disabling it? -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
