Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5658: addtl. process/system-wide memory metrics ......................................................................
Patch Set 5: Code-Review+2 (1 comment) Sorry for the delay http://gerrit.cloudera.org:8080/#/c/7472/2/be/src/util/mem-info.h File be/src/util/mem-info.h: PS2, Line 29: struct MappedMemInfo { : // Number of memory maps. : int64_t num_maps = 0; : : // Total size of memory maps (i.e. virtual memory size) in kilobytes. : int64_t size_kb = 0; : : // RSS in kilobytes : int64_t rss_kb = 0; > That makes sense because that predates THP. It seems ok to assume that if i Sure, I think this is fine behavior, I don't mean to hold this up. FWIW I think there are incompatibilities between these sort of interfaces and tools, but we don't have to expect new dot releases of platforms (e.g. rhel 6.x to 6.y) making big breaking changes. -- To view, visit http://gerrit.cloudera.org:8080/7472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13873e305ba464d11dea0d7244a29ff4f332f1a9 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
