Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7564/1/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: PS1, Line 119: // compute filters unnecessary PS1, Line 121: ctx_.getAnalysisResult().getTimeline().markEvent( : "Runtime filters computed"); single line? http://gerrit.cloudera.org:8080/#/c/7564/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: Line 538: * The assigned filters are the ones for which 'scanNode' can be used a destination update this comment PS1, Line 549: TRuntimeFilterMode runtimeFilterMode = : ctx.getQueryOptions().getRuntime_filter_mode(); single line? PS1, Line 590: : nit: space before ':' http://gerrit.cloudera.org:8080/#/c/7564/1/testdata/workloads/functional-query/queries/QueryTest/runtime_filters_distrib_pruning.test File testdata/workloads/functional-query/queries/QueryTest/runtime_filters_distrib_pruning.test: Line 1: ==== I suppose these are written as query tests and not planner tests because the planner tests don't have a good way to 'SET' on a per-test case basis? Its unfortunate and we should fix that (though I'm not saying you need to for this patch). -- To view, visit http://gerrit.cloudera.org:8080/7564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0f0b200e02442edcad8df3979f652d66c6e52eb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
