Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten ......................................................................
Patch Set 1: Code-Review+2 (3 comments) Nice, I think this looks good. I think we can commit this. Alex should weigh in when he's back to make sure we're not missing any other cases. http://gerrit.cloudera.org:8080/#/c/7567/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: PS1, Line 57: , though nit: can you put this in a separate sentence on the next line, e.g. // if false, this slot cannot be NULL. // NOTE: It is still possible... PS1, Line 58: for : // example as a result of this slot being outer joined on. nit: '..., for example as the result of an outer join.' http://gerrit.cloudera.org:8080/#/c/7567/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java: PS1, Line 103: * Simplify COALESCE by skipping leading nulls and applying the following transformations: : * COALESCE(null, a, b) -> COALESCE(a, b); : * COALESCE(<literal>, a, b) -> <literal>, when literal is not NullLiteral; : * COALESCE(<partition-slotref>, a, b) -> <partition-slotref>, : * when the partition column does not contain NULL. update -- To view, visit http://gerrit.cloudera.org:8080/7567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca6df949f9d416ab207016236dbcb5886295337 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
