Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/7526/6//COMMIT_MSG Commit Message: PS6, Line 26: FIXED_AGG_INTERMEDIATE > I think FIXED_UDA_INTERMEDIATE would be more precise/clear, especially sinc It wasn't too hard with some sed -i. PS6, Line 37: Testing: > any corner cases to consider for analytic fns? I think it should work fine, I couldn't think of any. I think it should work fine too. I agree we don't have many tests where analytics spill. I added a couple more tests in https://gerrit.cloudera.org/#/c/7552 but we could probably do with more. At least the spilling logic in the analytic is straightforward - most of the complication is in BufferedTupleStream which has a reasonable number of unit tests. http://gerrit.cloudera.org:8080/#/c/7526/6/be/src/runtime/types.cc File be/src/runtime/types.cc: PS6, Line 172: TypeToOdbcString > should types that aren't exposed raise a dcheck? Probably. Changed that in this case because we never will expose it. http://gerrit.cloudera.org:8080/#/c/7526/6/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: PS6, Line 1000: TODO > ? Done -- To view, visit http://gerrit.cloudera.org:8080/7526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife90cf27989f98ffb5ef5c39f1e09ce92e8cb87c Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
