Lars Volker has posted comments on this change.

Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
......................................................................


Patch Set 1:

> (1 comment)

I recently changed several places in the FE to use LinkedHashMaps in order to 
get deterministic ordering. That included ToSqlUtils.java:212, so I'm surprised 
the order is not deterministic. I suspect that file has the code that needs 
fixing, possibly L427 propertyMapToSql(). Maybe it'd be best to sort the 
properties to be completely independent from the underlying storage.

-- 
To view, visit http://gerrit.cloudera.org:8080/7575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64ce0c49fcbab3a4810d52c131bc176f8567ff9e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to