Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5757: Make tbl property toSql deterministic
......................................................................
Patch Set 1:
> > Didn't find any test cases that needed to be updated when I ran
> the
> > tests I was aware of using show create table. Possibly I missed
> > some, but will run a jenkins job.
>
> I'm surprised: it seems like kudu.master_addresses would sort
> before kudu.table_name
Agreed, but that's the order in the expected string:
props = "'kudu.table_name'='%s'" % kudu_table
self.assert_show_create_equals(cursor,
"""
CREATE TABLE {{table}} (c INT PRIMARY KEY)
PARTITION BY HASH (c) PARTITIONS 3
STORED AS KUDU
TBLPROPERTIES ({props})""".format(props=props),
"""
CREATE TABLE {db}.{{table}} (
c INT NOT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,
PRIMARY KEY (c)
)
PARTITION BY HASH (c) PARTITIONS 3
STORED AS KUDU
TBLPROPERTIES ('kudu.master_addresses'='{kudu_addr}',
{props})""".format(
--
To view, visit http://gerrit.cloudera.org:8080/7580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2391e04eb40e398098704b77588ad352d514df7d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-HasComments: No
