Tim Armstrong has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7581/1//COMMIT_MSG Commit Message: Line 9: For allowing multiple different distributions to build against the same Maybe briefly mention the relevant environment variables so it's more discoverable to people looking at the commit message only. http://gerrit.cloudera.org:8080/#/c/7581/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 39: HOST = "https://native-toolchain.s3.amazonaws.com/build"; It might make sense to also allow configuring this URL, so it can be pointed to an alternative source of the components. http://gerrit.cloudera.org:8080/#/c/7581/1/bin/impala-config.sh File bin/impala-config.sh: PS1, Line 131: cdh > is it too painful to change this string? i guess renaming would break exist Keeping it as cdh_components kind-of makes sense to me as long as we're putting CDH components in there, to allow parallel sets of components (e.g. apache_components). Or I guess maybe it could also make sense to have hadoop_components/ minicluster_components or something like that with everything under it, distinguished by version numbers. I don't feel strongly either way. -- To view, visit http://gerrit.cloudera.org:8080/7581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c2662e6f62adc924cc5de7a371202126046545 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
