Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift ......................................................................
Patch Set 3: Code-Review+2 (1 comment) Makes sense. I like the refactoring; we should probably be using the builder pattern in a few more cases where we have absurdly large constructors. http://gerrit.cloudera.org:8080/#/c/7524/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS3, Line 173: TODO: For 3.0 This should be tracked by a JIRA otherwise we might forget -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes