Tim Armstrong has posted comments on this change. Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7467/2//COMMIT_MSG Commit Message: Line 9: Googletest supports sharded execution, where multiple independent IIRC ctest also supports running multiple tests in parallel. How would the sharding fit with that? Would we shard big tests and run smaller tests in parallel? Line 30: Each shard process logs to its own directory 'foo_test_shard_N' under How would I know which output file to look at? http://gerrit.cloudera.org:8080/#/c/7467/2/bin/run-backend-tests.sh File bin/run-backend-tests.sh: Line 40: # mode. This includes all sharded tests, but also the non-sharded versions of any test The approach seems reasonable unless there's some built-in way to do this. Line 72: set +e What's this for? http://gerrit.cloudera.org:8080/#/c/7467/2/bin/run-sharded-test.sh File bin/run-sharded-test.sh: PS2, Line 35: NUM_SHARDS We should probably document this along with the input args. -- To view, visit http://gerrit.cloudera.org:8080/7467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865db25b07728f3886133316ded5122c60490967 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
