Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7630/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: Line 342: for (const auto& entry : per_backend_params) { > Nit: I think this will fit if you just do: Done http://gerrit.cloudera.org:8080/#/c/7630/4/be/src/scheduling/query-schedule.h File be/src/scheduling/query-schedule.h: Line 24: #include <boost/unordered_set.hpp> > This include might not be needed any more. Done -- To view, visit http://gerrit.cloudera.org:8080/7630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbcd1e9b1be14edc4017b4907e83f9d56059fbac Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
