Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build ......................................................................
Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/5717/18/LICENSE.txt File LICENSE.txt: Line 825: 3. All advertising materials mentioning features or use of this > I don't see that here: I'm following Apache Kudu's lead (https://github.com/apache/kudu/blob/master/LICENSE.txt), but I do now realise that I should have added the notice from #6 into NOTICE.txt). I don't think there is any advertising material that explicitly mentions X509 support (and it seems unlikely that there would be). If there were, it would have to include this notification, by my reading. -- To view, visit http://gerrit.cloudera.org:8080/5717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f327810066bee7f3ac107b0295480fb9ed45e14 Gerrit-PatchSet: 18 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
