Lars Volker has submitted this change and it was merged. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad ......................................................................
IMPALA-5477: Fix minidump-2-core tool in breakpad The recent PPC port broke the minidump-2-core tool in the toolchain. This change undoes a seemingly erroneous #ifdef to fix the tool on non-PPC systems. To test this, I built a toolchain locally and made sure that cores created from minidumps with the tool can be opened by GDB. I didn't test the change on PPC. Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2 --- M buildall.sh A source/breakpad/breakpad-1b704857f1e78a864e6942e613457e55f1aecb60-patches/0003-fix-md2core.patch 2 files changed, 20 insertions(+), 1 deletion(-) Approvals: Lars Volker: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/7658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2 Gerrit-PatchSet: 3 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
