Lars Volker has posted comments on this change. Change subject: IMPALA-5164: Better benchmark heuristic ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7389/2/be/src/util/benchmark.cc File be/src/util/benchmark.cc: Line 39: // is detecting context switches using getrusage(). Pass micro_heuristics=false to Can you add a sentence here to explain how that method helps to determine a run to be unreliable? PS2, Line 65: hopefully What if they don't? Will this loop run forever then? -- To view, visit http://gerrit.cloudera.org:8080/7389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6fb1283716dbc591c10238d85b9ab436d02fb96 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
