Jim Apple has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7581/2/bin/impala-config.sh File bin/impala-config.sh: Line 180: export DOWNLOAD_PACKAGED_COMPONENTS=${DOWNLOAD_PACKAGED_COMPONENTS-"$NO_THIRDPARTY"} > The proprietary stuff is what I'm actually trying to get rid of with this c Got it. However, my comment was trying to address the jargon of your comment, not the goal of the patch. I don't think there is any problem with the goal of the patch. -- To view, visit http://gerrit.cloudera.org:8080/7581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c2662e6f62adc924cc5de7a371202126046545 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes