Lars Volker has posted comments on this change. Change subject: IMPALA-5769: Add periodic minidump cleanup ......................................................................
Patch Set 2: (4 comments) Thanks for the reviews. Please see PS3. http://gerrit.cloudera.org:8080/#/c/7605/2/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: Line 233: assert self.wait_for_num_processes('impalad', cluster_size) == cluster_size > Isn't this racy? Since the minidump rotator could wake up before this runs. I'm not sure I understand your concern. Breakpad forks to write the minidump, so for a short period there are more impalad processes. We wait for these processes to be gone; afterwards all minidumps will be written. Then we wait an additional rotation_interval+1 seconds and only then do we count the number of minidump files. Line 237: expected_impalads = min(self.get_num_processes('impalad'), self.MAX_MINIDUMPS) > expected_impalad_minidumps might be clearer. Done PS2, Line 239: 2 > This relates to rotation_interval, so should probably be expressed as rotat Done Line 241: assert self.count_minidumps('statestored') == 1 > Can we also test sending multiple SIGUSR1 signals to the cluster to make su Done -- To view, visit http://gerrit.cloudera.org:8080/7605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie02ff2271412d814f84a4ff42ccbca51d91bf980 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
