Henry Robinson has posted comments on this change. Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7675/2/shell/TSSLSocketWithWildcardSAN.py File shell/TSSLSocketWithWildcardSAN.py: Line 50: self.SSL_VERSION = ssl.PROTOCOL_SSLv23 > Maybe mention that TSSLSocket forwards self.SSL_VERSION to the wrap_socket Done http://gerrit.cloudera.org:8080/#/c/7675/2/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: Line 108: @pytest.mark.xfail(run=True, reason="IMPALA-4295 on Centos6") > Can we xfail this more selectively if it's just an OS version issue? E.g. G I believe that we can skip based on the version of OpenSSL found, so I've changed the tests to do that. -- To view, visit http://gerrit.cloudera.org:8080/7675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5487f82d110676b9c3c7a5305931da00c7f68ca0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
