Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5796: CTAS for Kudu fails with expr rewrite ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7666/1/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java: Line 60: private final InsertStmt insertStmt_; > remove newline Done http://gerrit.cloudera.org:8080/#/c/7666/1/fe/src/main/java/org/apache/impala/analysis/TableDef.java File fe/src/main/java/org/apache/impala/analysis/TableDef.java: Line 205: if (isAnalyzed_) return; > Add this as the first line of this fn: Done http://gerrit.cloudera.org:8080/#/c/7666/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: Line 1594: // IMPALA-5796 - CTAS into a Kudu table with expr rewriting. > IMPALA-5796: CTAS into a Kudu table with expr rewriting. Done -- To view, visit http://gerrit.cloudera.org:8080/7666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia67bb33736b5a843663b226cdd0fa5bd839cbea1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes