Henry Robinson has posted comments on this change. Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0' ......................................................................
Patch Set 3: Code-Review+1 (3 comments) Thanks - this seems a lot better to me. Did you re-run test_finst_cancel? http://gerrit.cloudera.org:8080/#/c/7577/3/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS3, Line 971: VLOG_QUERY << "Backend completed: " : << " host=" << backend_state->impalad_address() : << " remaining=" << num_remaining_backends_ - 1; : if (VLOG_QUERY_IS_ON && num_remaining_backends_ > 1) { not your change, but while we're here: can you hoist the VLOG_QUERY_IS_ON check to include line 971? Line 987: } might be clearer just to return Status::OK() here, and avoid the need for an 'else'. PS3, Line 991: !backend_state->IsDone() let's remove this. I can see the race where IsDone() becomes true after line 953 if there are two concurrent reports, but I would expect it to be harmless. We also should really fix the possibility of concurrent reports properly - can you file a JIRA? -- To view, visit http://gerrit.cloudera.org:8080/7577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1528661e5df6d9732ebfeb414576c82ec5c92241 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
