Tianyi Wang has posted comments on this change.
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
......................................................................
Patch Set 2:
> > > Did you have a look at this comment in the JIRA?
> > >
> > > > Whoever implements this should be sure to test what happens
> to
> > > the printed summary in both the shell and the web UI (and
> > anywhere
> > > else it's printed, but that's all I'm aware of).
> >
> > I'm not sure if I understand it correctly. This does work for
> both
> > shell and web UI.
>
> I think the original author noticed that the summary in the
> impala-shell has the full column width, whereas the debug page
> truncates it. Why is one of them able to print the full string
> where the other is not?
Because among {shell, web}X{summary,profile}, <shell, summary> is the only one
that do pretty-print on client side. Commit message rephrased.
--
To view, visit http://gerrit.cloudera.org:8080/7691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae559913a98e32f77782161aa2b76e7c8a5dabd
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Tianyi Wang <[email protected]>
Gerrit-HasComments: No
