Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar ......................................................................
IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it is not handled in two places. This patch checks the return value/exception, logs if there is error and return error to the caller. A helper class JniUtfCharGuard is added to jni-util.h/cc to manage the lifetime. Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322 Reviewed-on: http://gerrit.cloudera.org:8080/7642 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/common/status.h M be/src/util/jni-util.cc M be/src/util/jni-util.h M be/src/util/logging-support.cc 4 files changed, 69 insertions(+), 26 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
