Pranay Singh has posted comments on this change. Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7709/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS1, Line 1817: that > whether that replaced by whether, done PS1, Line 1817: > double space Double space Removed PS1, Line 1819: int64_t session_timeout_min_ms = 1000; > Rename this to something like sleep_time_ms , and make it a constant - e.g. Made it a constant and changed it to uppercase PS1, Line 1844: FLAGS_use_local_tz_for_unix_timestamp_conversions = true; > This is very dangerous: what if some other thread reads FLAGS_use_local_tz_ Removed it http://gerrit.cloudera.org:8080/#/c/7709/1/be/src/service/session-expiry-test.cc File be/src/service/session-expiry-test.cc: PS1, Line 45: num_clients > constants should be ALL_CAPS Done -- To view, visit http://gerrit.cloudera.org:8080/7709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62f1ece6c128a80676c6eb331ef190a038bee76 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-HasComments: Yes
