Tim Armstrong has posted comments on this change. Change subject: IMPALA-5788: Fix agg node crash when grouping by nondeterministic exprs ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7714/2/be/src/exec/partitioned-aggregation-node.cc File be/src/exec/partitioned-aggregation-node.cc: PS2, Line 1487: AggFnEvaluator::FreeLocalAllocations(partition->agg_fn_evals); > Just want to make sure: It's idempotent, so should be fine (after it runs the first time there are no local allocations). I wouldn't worry about the perf. We already do this on 16 partitions on the more perf-critical non-spilling path, so this is no worse. I think if we wanted to optimise this, we'd focus on that case first. I'd prefer to keep the code simpler. http://gerrit.cloudera.org:8080/#/c/7714/2/testdata/workloads/functional-query/queries/QueryTest/spilling.test File testdata/workloads/functional-query/queries/QueryTest/spilling.test: Line 354: ---- RUNTIME_PROFILE > Exactly. There is no way to check for consistent results, so I just put a c The ones you have seem sufficient. -- To view, visit http://gerrit.cloudera.org:8080/7714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdb09239577b3f0a19d710b0d148e882b0b73e23 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
