Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7756
Change subject: IMPALA-5819: DCHECK in HdfsTextScanner::Close() ...................................................................... IMPALA-5819: DCHECK in HdfsTextScanner::Close() The DCHECK is only valid if the scanner successfully processes the entire scan range. If the scanner is cancelled or hits an error in-between buffers, boundary_column_ may be non-empty. The fix is to move the DCHECK to the end of FinishScanRange(), where it only executes if the scan range is fully processed. Testing: Ran TestCancellation in a loop locally for an hour. Change-Id: I3d63f0b0c1ac82103a60b68b244156b9fbd575e0 --- M be/src/exec/hdfs-text-scanner.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/7756/1 -- To view, visit http://gerrit.cloudera.org:8080/7756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d63f0b0c1ac82103a60b68b244156b9fbd575e0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]>
