Henry Robinson has posted comments on this change. Change subject: tidy: enable rule for constant naming ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7740/2//COMMIT_MSG Commit Message: PS2, Line 7: tidy: enable rule for constant naming > In some sense, the rule is the use of kFooBar. May be it's better to use th Right, but it a) doesn't apply to our whole codebase, so it isn't really a rule and b) I'm pretty sure that this refers to clang-tidy originally, and we do not use this rule in our clang-tidy setup. How about "Cherry-pick constant renaming for be/src/kudu from Kudu commit e719b" or something similar? -- To view, visit http://gerrit.cloudera.org:8080/7740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
