Alex Behm has posted comments on this change. Change subject: IMPALA-5504: Fix TupleIsNullPredicate evaluation. ......................................................................
Patch Set 2: Tim has a good point and I did investigate that. The underlying problem in this JIRA and in IMPALA-1987 is the same, but IMPALA-1987 did not fix is correctly. The code before the fix for IMPALA-1987 was not correct because it only checked the nullable tuples in that loop. But the predicate should always return false if there is at least one non-nullable tuple. The fix IMPALA-1987 for was still not correct for the reasons stated in the commit message here. -- To view, visit http://gerrit.cloudera.org:8080/7737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id659f849a68d88cfe22c65dd1747dd6d6a916163 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
