Sailesh Mukil has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/7674/9/shell/impala_shell.py File shell/impala_shell.py: PS9, Line 1069: check_readline IMO, this function doesn't help us much. I'd revert to not having this function. As for the repeated readline error to print, you can add the message as a string above in L49. READLINE_UNAVAILABLE_ERROR = "The readline module was either not found or disabled. Command history will not be collected." and print the string in the necessary places. PS9, Line 1092: history_length Rename to 'history_len' for consistency with other functions. -- To view, visit http://gerrit.cloudera.org:8080/7674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
