Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7760/1//COMMIT_MSG Commit Message: Line 16: It would also be good to mention that this contains the fix for the issues found while investigating IMPALA-5795, and what those fixes are. http://gerrit.cloudera.org:8080/#/c/7760/1/be/src/scheduling/backend-config.cc File be/src/scheduling/backend-config.cc: PS1, Line 93: GetBackendListForHost Would we not DCHECK inside here for if 'host' is the local_backend_descriptor_'s network address? Or would we not find it inside the LookupBackendIp() call too? http://gerrit.cloudera.org:8080/#/c/7760/1/be/src/scheduling/backend-config.h File be/src/scheduling/backend-config.h: PS1, Line 61: NULL nit: nullptr http://gerrit.cloudera.org:8080/#/c/7760/1/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: Line 710: ExecutorsConfigPtr config_ptr = GetExecutorsConfig(); I think it would be good to add a comment explaining why you pass the 'config_ptr' here instead of retrieving it inside ComputeScanRangeAssignment() itself. My guess is that we want a consistent view of the backends across the calls to ComputeScanRangeAssignment() and ComputeFragmentExecParams(), since the view of the backends can potentially change in between. -- To view, visit http://gerrit.cloudera.org:8080/7760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8707bfb5028bbe81d2a042fcf3e6e19f4b719a72 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
