Dan Hecht has posted comments on this change.

Change subject: IMPALA-5815: right outer join returns invalid memory
......................................................................


Patch Set 2: Code-Review+2

The comment is very similar to the one in NestedLoopJoinNode::NextProbeRow(), 
which shows that this model is very prone to errors (which we knew). Let's keep 
that in mind with the next phase of work to see what we can do to make this 
more "fool-proof".

-- 
To view, visit http://gerrit.cloudera.org:8080/7772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia14148499ddaec41c2e70fef5d53e5d06ea0538d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-HasComments: No

Reply via email to