Tim Armstrong has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner ......................................................................
Patch Set 9: Code-Review+2 (2 comments) One minor request then I'll merge. http://gerrit.cloudera.org:8080/#/c/7683/9/be/src/util/parse-util.cc File be/src/util/parse-util.cc: Line 99: void StringToDecimalSymbolDummy() { Can we move this to /exec/hdfs-scanner-ir.cc since that is the place that depends on it. Otherwise it will be hard to find. PS9, Line 100: emit "to link the object file". The compiler emits the .o but then the linker doesn't think that the .o file is needed by anything else in the impalad binary. -- To view, visit http://gerrit.cloudera.org:8080/7683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia65820e969d59094dc92d912a5279fa90f6b179d Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
