Dan Hecht has posted comments on this change. Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY ......................................................................
Patch Set 4: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/7771/4//COMMIT_MSG Commit Message: PS4, Line 9: open registered PS4, Line 11: opened registered http://gerrit.cloudera.org:8080/#/c/7771/4/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: Line 492: // registered. maybe dcheck that either the buffer pool client is registered or the phase is {prepare,open}, to avoid this kind of issue creeping in unnoticed again? -- To view, visit http://gerrit.cloudera.org:8080/7771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib26b697544d6c2312a8e1fe91b0cf8c0917e5603 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
