Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7640/9/be/src/runtime/disk-io-mgr-handle-cache.inline.h File be/src/runtime/disk-io-mgr-handle-cache.inline.h: PS9, Line 190: bool timed_out = true; : // This Get() will time out until shutdown, when the promise is set. : while (timed_out) { this is weird. normally I'm not in favor of while (true), but in this case I think this code would be more clear if this was: while (true) { ... bool timed_out; shut_down_promise_.Get(period, &timed_out); if (!timed_out) break; } ... -- To view, visit http://gerrit.cloudera.org:8080/7640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefe04b3e2e22123ecb8b3e494934c93dfb29682e Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
