Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5784 : Separate planner and user set query options in 
profile
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7721/3/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

PS3, Line 149: manually
Hm. This word may be misleading, query options may have been set when assigned 
to an admission control pool, i.e. the per-pool defaults. Also there are 
server-wide defaults that can be set by the gflag -default_query_options, and 
those would show up here too.

'manually or automatically set' is more precise, but verbose. Lets see if Dan 
or Balasz have suggestions.


-- 
To view, visit http://gerrit.cloudera.org:8080/7721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc7832963fa0bd278a45c06a5a54e1bf40d8876
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Balazs Jeszenszky <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-HasComments: Yes

Reply via email to