Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5798: ASAN use-after-poison in Parquet decoder ......................................................................
IMPALA-5798: ASAN use-after-poison in Parquet decoder In ParquetLevelDecoder::Init() for RLE encoding, we read the metadata size and advance the data buffer past it. If the metadata size is corrupted, it can cause us to incorrectly read past the end of the buffer. This patch checks that the metadata size is less than the total size of the buffer, and returns an error if it isn't. Testing: - Ran test_scanners_fuzz.py under ASAN 500 times without hitting the use-after-poison (previously it would usually hit in < 100 runs). Change-Id: I3f3d0d998f7581c7c935d98fde886f145efd61a8 Reviewed-on: http://gerrit.cloudera.org:8080/7769 Reviewed-by: Alex Behm <[email protected]> Reviewed-by: Matthew Jacobs <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/parquet-column-readers.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Matthew Jacobs: Looks good to me, approved Alex Behm: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/7769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f3d0d998f7581c7c935d98fde886f145efd61a8 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
