Henry Robinson has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. ......................................................................
Patch Set 3: (4 comments) just passing through. http://gerrit.cloudera.org:8080/#/c/7781/3//COMMIT_MSG Commit Message: PS3, Line 12: I did the naive thing for recognizing that ifnull has variants. nit: not clear what this means (becomes clear upon reading the patch). Might be more helpful to say that you hardcoded the set of ifnull aliases. http://gerrit.cloudera.org:8080/#/c/7781/3/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java: Line 55: private static List<String> IFNULL_ALIASES = ImmutableList.of("ifnull", "isnull", "nvl"); nit: long line (by one character) Line 107: private Expr simplifyIfNullFunctionCallExpr(FunctionCallExpr expr) { static? PS3, Line 148: ifnull update comment -- To view, visit http://gerrit.cloudera.org:8080/7781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e4b8bf6fedd595f9ea54ffb30fc71a058c7f16c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-HasComments: Yes
