Henry Robinson has posted comments on this change. Change subject: Hide some deprecated flags ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7786/1//COMMIT_MSG Commit Message: Line 7: Hide some deprecated flags > Can you add a JIRA number? Can you also comment on what the effect of the h There isn't a JIRA number. Is one necessary? For tiny changes like this we don't always have a JIRA. http://gerrit.cloudera.org:8080/#/c/7786/1/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: PS1, Line 74: Deprecated - has no effect > Can we use the same error message for deprecated flags across all files? Since the message isn't user-visible after the flag is hidden, what would be the benefit of doing so? -- To view, visit http://gerrit.cloudera.org:8080/7786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I948b46cd6853f1d8ebaaadaba7b801dca886c7ad Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
