Pranay Singh has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7729/1//COMMIT_MSG Commit Message: PS1, Line 17: reduce > what's the reason to reduce this time? Since the frequency of polling is session-timeout/2 where session-timeout is 1sec, 4 sec should be good enough a tight upper bound so I used 4 sec as idle session timeout Line 18: of max_idle_timeout_ms > let's generally keep the messages left justified (exception inside formatte OK http://gerrit.cloudera.org:8080/#/c/7729/1/be/src/service/session-expiry-test.cc File be/src/service/session-expiry-test.cc: PS1, Line 68: gets one session eac > since we're really trying to create multiple sessions (and just using clien Done PS1, Line 83: 10 > that looks like it should be expressed in terms of NUM_CLIENTS. Done PS1, Line 87: 5s > 5s should be updated if you're changing that value. Done PS1, Line 88: 5L > isn't that NUM_CLIENTS? Done -- To view, visit http://gerrit.cloudera.org:8080/7729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I827a5fa2246e7b05b718fb8b4563b8488c91a1d9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-HasComments: Yes
