Tim Armstrong has posted comments on this change. Change subject: IMPALA-5570: fix spilling null-aware anti join ......................................................................
Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/7367/12/tests/query_test/test_spilling.py File tests/query_test/test_spilling.py: Line 66: and therefore will not reliably pass with the deny reservation debug action enabled. > do we plan to fix that (and a jira) or is this case not important enough? I guess there are two reasons: one are the tests where scratch_limit=0, where that's just the nature of the test. The second is the build side limitation. I filed IMPALA-5834 for that. It's unclear how important it is but it seems worth noting. There's a similar issue if there's a large number of duplicate values as well. I think both boil down to doing a spilling nested-loop join. -- To view, visit http://gerrit.cloudera.org:8080/7367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e60eb4dd32bd287a31479a6232400df65964c1 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
