Michael Brown has posted comments on this change. Change subject: IMPALA-5625: stress test: write profile when queries fail ......................................................................
Patch Set 2: (2 comments) Almost there. http://gerrit.cloudera.org:8080/#/c/7376/2/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS2, Line 1668: get_profile > I was debating that myself but decided that, since the major activity is fe The first word in the docstring is "set". :) fetch_profile() is OK, but the function has a side-effect, in that report.profile is set after execution. Thoughts? PS2, Line 1670: Producing a query profile can be somewhat expensive. A v-tune profile of : impalad showed 10% of cpu time spent generating query profiles. > I haven't looked at performance. At first I was concerned that collecting p Done -- To view, visit http://gerrit.cloudera.org:8080/7376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dbdf5fcf97d6c5681c9fc8fb9eb448bc459b3b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Mulder <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-HasComments: Yes
