Tianyi Wang has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7776/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1210: CollectionValueBuilder* coll_value_builder, int64_t* num_coll_item_read) { > Can you remove these from the function signatures (see my comment in the he Done Line 1277: (*num_coll_item_read) += rows_read; > are the () needed here? No. Code removed. http://gerrit.cloudera.org:8080/#/c/7776/2/be/src/exec/parquet-column-readers.h File be/src/exec/parquet-column-readers.h: PS2, Line 505: > removing the virtual keyword breaks consistency with the other methods in t Reverted. -- To view, visit http://gerrit.cloudera.org:8080/7776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f6efddaea18507482940f5bdab7326b6482b067 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
