Philip Zeyliger has posted comments on this change. Change subject: IMPALA-3642: Adding backend addresses to error statuses for scratch failures. ......................................................................
Patch Set 1: I'm looking for feedback on whether we have more explicit ways to test this sort of thing. This only tackles one particular source of errors. There are ~294 matches for Status.*Substitute, and of these some (like the runtime errors in filesystem-util.cc) could compellingly make a case for similar treatment. The way Statuses are propagated down to the query is not trivial, though one could add a "source host" field to the relevant Thrift structure and populate it for non-OK statuses in Status::ToThrift(). (Or, even just append it to any messages in an unstructured way.) -- To view, visit http://gerrit.cloudera.org:8080/7816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If31a50fdf6031312d0348d48aeb8f9688274cac2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-HasComments: No
