Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7781/6/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java: Line 105: * Simplifies IFNULL if the condition is a literal, using the > by returning the appropriate child Done http://gerrit.cloudera.org:8080/#/c/7781/6/testdata/workloads/functional-planner/queries/PlannerTest/simplify-expressions.test File testdata/workloads/functional-planner/queries/PlannerTest/simplify-expressions.test: Line 1 > No worries. Just to explain: Planner tests change very often, mostly for re Thanks. This all makes sense. I learned a little bit about the planner tests, and I was, indeed, wondering how miserable they are to maintain! -- To view, visit http://gerrit.cloudera.org:8080/7781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e4b8bf6fedd595f9ea54ffb30fc71a058c7f16c Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-HasComments: Yes
